fix(tooling): close rename blind spot in asset hash check#7
Merged
Conversation
Check (b) previously validated references only in three hardcoded files, so renaming a hashed asset referenced from an article or from the stylesheet's font url()s passed all checks while breaking the site. Discover referencing files with git grep instead; vendored trees stay excluded because FONTLOG.txt carries commit-pinned permalinks that are valid without existing on disk. Re-add the template existence guard that the hardcoded list used to provide. Verified: a hash-preserving rename of an article-referenced image now fails check (b) and only check (b).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #6, fixing the one substantive finding from its post-merge review: the hash-integrity check validated references only in three hardcoded files, so renaming a hashed asset referenced from an article (30+ image refs across 4 articles) or from the stylesheet's font
url()s passed all checks while breaking the site.Changes
git grepover tracked text files instead of a hardcoded list, with vendored trees excluded (fonts/*/FONTLOG.txtcarries commit-pinned permalinks that are valid without existing on disk).Testing
pre-commit run --all-filesgreen.